Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum array error #47

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fix enum array error #47

merged 4 commits into from
Dec 11, 2024

Conversation

leah-u
Copy link
Contributor

@leah-u leah-u commented Dec 2, 2024

This fixes #46. I'm not very experienced with database stuff so I'm happy for any feedback.

The codebase was very pleasant to work with btw :)

@giacomocavalieri
Copy link
Owner

Thank you so much!! I'm really happy you enjoyed working on this 💜
Right now I'm on a trip without great internet connection but I'll check this as soon as I can!

Copy link
Owner

@giacomocavalieri giacomocavalieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I've just left a comment inline.
Also could you update the CHANGELOG with the fix?

src/squirrel/internal/query.gleam Outdated Show resolved Hide resolved
@leah-u
Copy link
Contributor Author

leah-u commented Dec 4, 2024

Should be all good now :)

@giacomocavalieri
Copy link
Owner

Lovely work, thank you! Sorry it took me so long to merge this I had a couple of packed days at a conference 😅

@giacomocavalieri giacomocavalieri merged commit b78aa00 into giacomocavalieri:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrays of enums don't work
2 participants